Skip to content

fix(find-updates): honor configured source resolvers - #1408

Merged
LalatenduMohanty merged 1 commit into
python-wheel-build:new-resolver-configfrom
jlarkin09:codex/1401-find-updates-source-resolver
Oct 30, 2026
Merged

fix(find-updates): honor configured source resolvers#1408
LalatenduMohanty merged 1 commit into
python-wheel-build:new-resolver-configfrom
jlarkin09:codex/1401-find-updates-source-resolver

Conversation

@jlarkin09

@jlarkin09 jlarkin09 commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Use sources.get_source_provider() for packages with source configuration while preserving legacy provider hooks, distribution options, and index overrides. Update reports ignore global and per-package release-age cooldowns so recent releases remain visible with either configuration style.

Add CLI regression coverage for source profiles, variant overrides, legacy settings, and mixed-age or all-recent releases with cooldowns enabled.

Validation: 436 focused tests passed with coverage; Ruff and mypy passed. A live PyPI CLI check with --min-release-age 3650 still reported all 14 updates for idna==3.6.

Closes: #1401

@jlarkin09
jlarkin09 requested a review from a team as a code owner October 28, 2026 18:31
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jlarkin09 jlarkin09 self-assigned this Oct 28, 2026
@mergify mergify Bot added the ci label Oct 28, 2026
@mergify

mergify Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.
@jlarkin09 please rebase your branch.

rd4398
rd4398 reviewed Oct 28, 2026
View reviewed changes

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I have left a comment and a suggestion.

I would appreciate if @LalatenduMohanty and @smoparth take a look as well

Comment thread src/fromager/commands/find_updates.py Resolved
@rd4398 rd4398 mentioned this pull request Oct 28, 2026
Open
1 task done
@jlarkin09 @codex
fix(find-updates): honor configured source resolvers
8809c85 
Use `sources.get_source_provider()` for packages with source configuration
while preserving legacy provider hooks, distribution options, and index
overrides. Keep release-age cooldowns out of update reports so recent
releases remain visible. Add CLI regression coverage and document behavior.

Closes: python-wheel-build#1401
Co-Authored-By: GPT Sol <noreply@openai.com>
Signed-off-by: Justin Larkin <jlarkin@redhat.com>
@jlarkin09
jlarkin09 force-pushed the codex/1401-find-updates-source-resolver branch from 5e3bce0 to 8809c85 Compare October 28, 2026 21:19
@LalatenduMohanty LalatenduMohanty mentioned this pull request Oct 28, 2026
Open
@LalatenduMohanty

LalatenduMohanty commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks, looks good. This matches the approach agreed in the #1407 (comment) thread: ignore the cooldown for both kinds of package, keep the old path as it is, and keep --distribution-type in the command. #1407 should follow the same pattern.

@mergify

mergify Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@LalatenduMohanty LalatenduMohanty mentioned this pull request Oct 30, 2026
Open
rd4398
rd4398 approved these changes Oct 30, 2026
View reviewed changes

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LalatenduMohanty
LalatenduMohanty merged commit 93c2e3f into python-wheel-build:new-resolver-config Oct 30, 2026
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes
@rd4398 rd4398 rd4398 approved these changes

Assignees

@jlarkin09 jlarkin09

Labels

ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jlarkin09 @LalatenduMohanty @rd4398